Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Background for Tabbar Icon #1043

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Background for Tabbar Icon #1043

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dd6a4b
fix: Background for Tabbar Icon
Darsh0307 Nov 3, 2023
da3c271
fix: SurfaceBrush for tabbar icon
Nov 20, 2023
8663bfa
fix: Background for Tabbar Icon
Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Uno.Gallery/Uno.Gallery.Shared/Views/NestedPages/MaterialTopBarSampleNestedPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:utu="using:Uno.Toolkit.UI"
mc:Ignorable="d"
Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">
Background="{ThemeResource SurfaceBrush}">

<Grid>
<Grid.RowDefinitions>
Expand Down Expand Up @@ -42,32 +42,32 @@
<Grid x:Name="Home" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

<StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
<FontIcon Glyph="{StaticResource HomeIcon}" />
<TextBlock Text="Home" TextAlignment="Center" />
<FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{ThemeResource HomeIcon}" />
kazo0 marked this conversation as resolved.
Show resolved Hide resolved
<TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Home" TextAlignment="Center" />
</StackPanel>
</Border>
</Grid>
<Grid x:Name="Search" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

<StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
<FontIcon Glyph="{StaticResource SearchIcon}" />
<TextBlock Text="Search" TextAlignment="Center" />
<FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{ThemeResource SearchIcon}" />
<TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Search" TextAlignment="Center" />
</StackPanel>
</Border>
</Grid>
<Grid x:Name="Support" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

<StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
<FontIcon Glyph="{StaticResource SupportIcon}" />
<TextBlock Text="Support" TextAlignment="Center" />
<StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
<FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{ThemeResource SupportIcon}" />
<TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Support" TextAlignment="Center" />
</StackPanel>
</Border>
</Grid>
<Grid x:Name="About" Visibility="Collapsed">
<Border Background="LightGray">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray

<StackPanel HorizontalAlignment="Center" VerticalAlignment="Center">
<FontIcon Glyph="{StaticResource AboutIcon}" />
<TextBlock Text="About" TextAlignment="Center" />
<FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{ThemeResource AboutIcon}" />
<TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="About" TextAlignment="Center" />
</StackPanel>
</Border>
</Grid>
Expand Down
Loading