feat(ProgressBar): Progress bars style can now be overrided using lig… #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-999.eastus2.azurestaticapps.net |
kazo0
reviewed
May 26, 2023
Marc-Antoine-Soucy
force-pushed
the
dev/maso/lightweightprogressbar
branch
from
ad090dd to
3ca387a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-999.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-999.eastus2.azurestaticapps.net |
kazo0
reviewed
Jun 2, 2023
Marc-Antoine-Soucy
force-pushed
the
dev/maso/lightweightprogressbar
branch
from
b8068a7 to
78d8992
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-999.eastus2.azurestaticapps.net |
kazo0
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…htweight styling
GitHub Issue: #
PR Type
What kind of change does this PR introduce?
Description
I made it so you can change the style of the progress bar using the pattern and also updated the progress bar so that it reflects figma's design.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
new style vs figma's style:
The progress bar doesnt work well on android, but it also doesnt work well on master. (in both, you only see the background of the progressbar)
Internal Issue (If applicable):
#994