Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: lightweight styling #713

Merged
merged 1 commit into from
Aug 17, 2023
Merged

docs: lightweight styling #713

merged 1 commit into from
Aug 17, 2023

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Aug 10, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #712

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Adds a documentation page for each control that can be lightweight styled.

PR Checklist

Please check if your PR fulfills the following requirements:

@rajamatt rajamatt self-assigned this Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@rajamatt
Copy link
Contributor Author

@kazo0 did you want a general lightweight styling page for toolkit too?

@rajamatt
Copy link
Contributor Author

@kazo0 I noticed some controls don't have default styles at all whereas in Uno.Themes all of the controls had one

as for in the code, I can't really tell which styles are the default ones, could it be there's no default?

@rajamatt
Copy link
Contributor Author

@kazo0 should I separated TabBar.md into TabBar.md and TabBarItem.md or can I just put TabBarItem in TabBar?

@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Aug 10, 2023

@kazo0 did you want a general lightweight styling page for toolkit too?

@rajamatt yeah we should have some sort of general docs page about it, similar to the themes ones

@kazo0
Copy link
Contributor

kazo0 commented Aug 10, 2023 •
edited by unfurl-links bot
Loading

@kazo0 should I separated TabBar.md into TabBar.md and TabBarItem.md or can I just put TabBarItem in TabBar?

@rajamatt now that I'm seeing the pages, it probably makes more sense to just add a Lightweight Styling section to the already existing pages for each control. Like here: https://platform.uno/docs/articles/external/uno.toolkit.ui/doc/controls/CardAndCardContentControl.html

@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 4bacfe1 to 6ea354e Compare August 11, 2023 14:20
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

Youssef1313
Youssef1313 reviewed Aug 12, 2023
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tables auto generated?

@rajamatt
Copy link
Contributor Author

rajamatt commented Aug 14, 2023 •
edited
Loading

Are these tables auto generated? @Youssef1313

Yes the lightweight styling tables are generated by a script.

@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 918caef to c7f68d7 Compare August 14, 2023 14:10
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@agneszitte agneszitte linked an issue Aug 14, 2023 that may be closed by this pull request
[Material] Lightweight Styling - Documentation unoplatform/Uno.Themes#1063
Closed
17 tasks
@agneszitte agneszitte removed a link to an issue Aug 14, 2023
[Material] Lightweight Styling - Documentation unoplatform/Uno.Themes#1063
Closed
17 tasks
mrlacey
mrlacey reviewed Aug 14, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
mrlacey
mrlacey reviewed Aug 14, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 4634b1f to 42d2070 Compare August 15, 2023 16:24
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

jeromelaban
jeromelaban approved these changes Aug 16, 2023
View reviewed changes
doc/lightweight-styling.md Show resolved Hide resolved
@jeromelaban jeromelaban mentioned this pull request Aug 16, 2023
Merged
6 tasks
@rajamatt
docs: lightweight styling
6eb5d25 
docs: updated toc.yml

docs: added general lightweight styling page

docs: put lightweight keys in control files

docs: lightweight styling

fix: various spacing and missing lines

docs: lightweight styling

fix: wording

docs: lightweight styling

docs: added xref and removed info

fix: typo

docs: lightweight styling
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 7ff3fed to 6eb5d25 Compare August 16, 2023 20:44
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-713.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

Last sanity check @jeromelaban, @Xiaoy312, @pictos please

@agneszitte agneszitte merged commit fe13f57 into main Aug 17, 2023
@agneszitte agneszitte deleted the dev/mara/docs-lightweight-styling branch August 17, 2023 17:51
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/3x

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023 •
edited
Loading

backport legacy/3x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@rajamatt @mergify
docs: lightweight styling (#713)
f26166c 
(cherry picked from commit fe13f57)
@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
agneszitte pushed a commit that referenced this pull request Aug 17, 2023
@mergify @rajamatt
docs: lightweight styling (backport #713) (#733)
8b40821 
Co-authored-by: Matthew Rajala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlacey mrlacey mrlacey left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

@pictos pictos pictos approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@kazo0 kazo0 Awaiting requested review from kazo0

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Lightweight Styling
7 participants
@rajamatt @kazo0 @agneszitte @mrlacey @jeromelaban @pictos @Youssef1313