Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid Local overwriting Animation value in certain cases #16029

Merged
merged 8 commits into from
Mar 28, 2024
Merged

fix: Avoid Local overwriting Animation value in certain cases #16029

merged 8 commits into from
Mar 28, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Mar 26, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #16006 closes #15978 closes #16007

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 marked this pull request as draft March 26, 2024 11:04
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

dr1rrb
dr1rrb reviewed Mar 26, 2024
View reviewed changes
src/Uno.UI/UI/Xaml/FrameworkElement.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/VisualStateGroup.cs Outdated Show resolved Hide resolved
@Youssef1313 Youssef1313 mentioned this pull request Mar 26, 2024
Closed
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@Youssef1313 Youssef1313 changed the title fix: Re-evaluate visual state setters on theme change fix: Avoid Local overwriting Animation value in certain cases Mar 27, 2024
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Mar 27, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@Youssef1313 Youssef1313 mentioned this pull request Mar 28, 2024
Closed
This was referenced Mar 28, 2024
Closed
Closed
Closed
@Youssef1313 Youssef1313 marked this pull request as ready for review March 28, 2024 08:37
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16029/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16029/index.html

@dr1rrb dr1rrb merged commit f24671c into unoplatform:master Mar 28, 2024
102 checks passed
@Youssef1313 Youssef1313 deleted the issues/16004 branch March 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
3 participants
@Youssef1313 @unodevops @dr1rrb