Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] FileOpenPicker, FolderPicker, StorageFile & StorageFolder operations #5485

Merged
merged 17 commits into from
Mar 18, 2021

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Mar 17, 2021

GitHub Issue (If applicable): closes #4027, closes #5226, closes #3890, closes #5228, closes #5231

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Not supported

What is the new behavior?

Supported

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund requested a review from a team March 17, 2021 08:30
@gitpod-io
Copy link

gitpod-io bot commented Mar 17, 2021

Copy link
Contributor

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure these changes were intended

src/Uno.UWP/Storage/StorageFolder.Local.cs Outdated Show resolved Hide resolved
src/Uno.UWP/Storage/Streams/FileRandomAccessStream.iOS.cs Outdated Show resolved Hide resolved
@@ -71,6 +71,11 @@ public static class FileTypes
/// Allows definition of custom file type MIME mappings.
/// </summary>
public static Dictionary<string, string> FileTypeToMimeMapping { get; } = new Dictionary<string, string>();

/// <summary>
/// Allows definition of custom file type UTType mappings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs article ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be part of the docs I am writing for pickers, not yet complete

@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Mar 17, 2021
@MartinZikmund MartinZikmund force-pushed the dev/mazi/ios-pickers-final branch 2 times, most recently from fc68339 to c09312b Compare March 18, 2021 00:16
@MartinZikmund MartinZikmund force-pushed the dev/mazi/ios-pickers-final branch from e99a61e to acaa7b6 Compare March 18, 2021 09:11
@mergify mergify bot merged commit a6bb7ec into unoplatform:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
5 participants