Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RangeCalendar): enable modelValue to be undefined and refactor combined watch condition #1612

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Feb 10, 2025

Closes #1611.

@epr3 epr3 requested a review from zernonia February 10, 2025 21:45
@epr3 epr3 self-assigned this Feb 10, 2025
@zernonia
Copy link
Member

@epr3 seems like setting to undefined (range = undefined) is throwing some error, I think we should cater for this case too 😁

@epr3
Copy link
Collaborator Author

epr3 commented Feb 11, 2025

@zernonia Could you provide a screenshot of the error? I don't seem to be able to reproduce any error on Histoire. 🤷🏻

Screen.Recording.2025-02-11.at.18.52.21.mov

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok now!

@zernonia zernonia merged commit 9ac65f5 into main Feb 12, 2025
3 checks passed
Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

npm i https://pkg.pr.new/radix-vue@1612

commit: 52bc77f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RangeCalendar display does not update when cleared programmatically
2 participants