Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization of solgo path structure #10

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Conversation

0x19
Copy link
Contributor

@0x19 0x19 commented Jul 2, 2023

Does not make sense that all of the go code is in the main path. Instead, I've built sub packages for now for contracts and abis. As well introduced common.

Abis is intentional as a lot of packages in go use "abi" package name so making it "abis" creates imports easier.

@0x19 0x19 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 2, 2023
@0x19 0x19 self-assigned this Jul 2, 2023
@coveralls
Copy link

coveralls commented Jul 2, 2023

Pull Request Test Coverage Report for Build 5436941273

  • 33 of 40 (82.5%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.7%) to 68.387%

Changes Missing Coverage Covered Lines Changed/Added Lines %
abis/parser.go 27 34 79.41%
Files with Coverage Reduction New Missed Lines %
solgo.go 2 94.29%
Totals Coverage Status
Change from base Build 5431386318: 2.7%
Covered Lines: 424
Relevant Lines: 620

💛 - Coveralls

@0x19 0x19 merged commit 12d640e into main Jul 2, 2023
@0x19 0x19 deleted the refactor-package-organization branch July 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants