Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract package multi line comment support #20

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Contract package multi line comment support #20

merged 1 commit into from
Jul 3, 2023

Conversation

0x19
Copy link
Contributor

@0x19 0x19 commented Jul 3, 2023

In the past multi line comments were not extracted when parsing contract. This is now fixed.

This ticket closes #4

@0x19 0x19 added bug Something isn't working contracts Contracts labels Jul 3, 2023
@0x19 0x19 self-assigned this Jul 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5448508912

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 76.748%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/contract_listener.go 9 10 90.0%
Totals Coverage Status
Change from base Build 5448346529: 0.08%
Covered Lines: 878
Relevant Lines: 1144
💛 - Coveralls

@0x19 0x19 merged commit 50eb954 into main Jul 3, 2023
@0x19 0x19 deleted the contract-multi-comments branch July 3, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0x19 0x19

Labels
bug Something isn't working contracts Contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research and resolve multi line comments parsing
2 participants
@0x19 @coveralls