Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Contract ABI resolver fix (phase A) #27

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Multi Contract ABI resolver fix (phase A) #27

merged 2 commits into from
Jul 11, 2023

Conversation

0x19
Copy link
Contributor

@0x19 0x19 commented Jul 11, 2023 •
edited
Loading

In this phase, if multiple contracts are provided within the single file including libraries and interfaces, correct abi will be built and displayed.

Additionaly, common package is now obsolete. Each respective package has it's own types.go.

Following PR closes #26

@0x19 0x19 added bug Something isn't working enhancement New feature or request abi Application Binary Interface labels Jul 11, 2023
@0x19 0x19 self-assigned this Jul 11, 2023
@0x19 0x19 linked an issue Jul 11, 2023 that may be closed by this pull request
ABI parse from multiple contracts #26
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5521707764

  • 78 of 104 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 76.447%
Changes Missing Coverage Covered Lines Changed/Added Lines %
abis/helpers.go 10 14 71.43%
abis/parser.go 46 68 67.65%
Totals Coverage Status
Change from base Build 5449521846: 0.5%
Covered Lines: 951
Relevant Lines: 1244
💛 - Coveralls

@0x19 0x19 merged commit 6fca24f into main Jul 11, 2023
@0x19 0x19 deleted the 26-multi-contract-abi branch July 11, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0x19 0x19

Labels
abi Application Binary Interface bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ABI parse from multiple contracts
2 participants
@0x19 @coveralls