Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem about the code. #31

Open
niuchuangnn opened this issue Jan 2, 2019 · 5 comments
Open

Problem about the code. #31

niuchuangnn opened this issue Jan 2, 2019 · 5 comments

Comments

@niuchuangnn
Copy link

int num_kernels = height_col * width_col * 2 * kernel_h * kernel_h * deformable_group;

Should be int num_kernels = height_col * width_col * 2 * kernel_h * kernel_w * deformable_group; ?

@niuchuangnn
Copy link
Author

this->conv_in_channels_,this->conv_input_shape_.cpu_data()[1],this->conv_input_shape_.cpu_data()[2],this->col_buffer_.shape(0),

Should be this->conv_in_channels_,this->conv_input_shape_.cpu_data()[1],this->conv_input_shape_.cpu_data()[2],this->col_buffer_.count(0), ?

@niuchuangnn
Copy link
Author

Hi, @unsky, there may be some bugs in your code. Could you spend a few minutes to check that #31 (comment). Thank you.

@niuchuangnn
Copy link
Author

this->dilation_.cpu_data()[0],this->dilation_.cpu_data()[1],this->deformable_group_,bottom_diff+ n*this->input_offset_dim_);

Should be bottom_diff+ n*this->bottom_dim_?

@unsky
Copy link
Owner

unsky commented Jan 8, 2019

时间过去太久了,有些细节可能有些问题,可能没考虑更多的边界问题,但细节忘光了,工作比较忙,你可以尝试自己做实验,看看在实验上的效果,如果有兴趣可以帮我提个pr,感谢。我目前对这份代码只能保证这份code可以跑出readme上的效果。

@niuchuangnn
Copy link
Author

@unsky 谢谢您的回复。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants