Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECW 3026] Added okb erc20 and deprecate okc erc20 #318

Merged

Conversation

tunguyennnnn
Copy link
Contributor

@tunguyennnnn tunguyennnnn commented Jan 22, 2024

PR Checklist

Context: https://linear.app/unstoppable-domains/issue/ECW-3026/update-currency-okc-token

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@tunguyennnnn tunguyennnnn force-pushed the tunguyen/ECW-3026-deprecate-okc-and-add-okb-erc20 branch from b8981c1 to 5b6383e Compare January 22, 2024 20:47
@tunguyennnnn tunguyennnnn requested review from a team and V-Shadbolt January 22, 2024 20:47
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 17.249 0
ProxyReader 15.176 0
UNSRegistry 19.943 0

@tunguyennnnn tunguyennnnn requested review from a team and bonsaiben and removed request for a team January 22, 2024 20:49
@tunguyennnnn tunguyennnnn marked this pull request as ready for review January 22, 2024 20:49
@tunguyennnnn tunguyennnnn merged commit de4febb into main Jan 23, 2024
8 checks passed
@tunguyennnnn tunguyennnnn deleted the tunguyen/ECW-3026-deprecate-okc-and-add-okb-erc20 branch January 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants