[REG-1409]feat: add multicall to the sandbox #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contracts size report
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+40
to
+54
| function aggregate(Call[] calldata calls) public payable returns (uint256 blockNumber, bytes[] memory returnData) { | ||
| blockNumber = block.number; | ||
| uint256 length = calls.length; | ||
| returnData = new bytes[](length); | ||
| Call calldata call; | ||
| for (uint256 i = 0; i < length; ) { | ||
| bool success; | ||
| call = calls[i]; | ||
| (success, returnData[i]) = call.target.call(call.callData); | ||
| require(success, 'Multicall3: call failed'); | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / Slither
Calls inside a loop Low
Comment on lines
+40
to
+54
| function aggregate(Call[] calldata calls) public payable returns (uint256 blockNumber, bytes[] memory returnData) { | ||
| blockNumber = block.number; | ||
| uint256 length = calls.length; | ||
| returnData = new bytes[](length); | ||
| Call calldata call; | ||
| for (uint256 i = 0; i < length; ) { | ||
| bool success; | ||
| call = calls[i]; | ||
| (success, returnData[i]) = call.target.call(call.callData); | ||
| require(success, 'Multicall3: call failed'); | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+61
to
+74
| function tryAggregate(bool requireSuccess, Call[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call calldata call; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| call = calls[i]; | ||
| (result.success, result.returnData) = call.target.call(call.callData); | ||
| if (requireSuccess) require(result.success, 'Multicall3: call failed'); | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / Slither
Calls inside a loop Low
Comment on lines
+61
to
+74
| function tryAggregate(bool requireSuccess, Call[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call calldata call; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| call = calls[i]; | ||
| (result.success, result.returnData) = call.target.call(call.callData); | ||
| if (requireSuccess) require(result.success, 'Multicall3: call failed'); | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+106
to
+133
| function aggregate3(Call3[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3 calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| (result.success, result.returnData) = calli.target.call(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x64) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / Slither
Calls inside a loop Low
Comment on lines
+139
to
+175
| function aggregate3Value(Call3Value[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 valAccumulator; | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3Value calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| uint256 val = calli.value; | ||
| // Humanity will be a Type V Kardashev Civilization before this overflows - andreas | ||
| // ~ 10^25 Wei in existence << ~ 10^76 size uint fits in a uint256 | ||
| unchecked { | ||
| valAccumulator += val; | ||
| } | ||
| (result.success, result.returnData) = calli.target.call{value: val}(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x84) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| // Finally, make sure the msg.value = SUM(call[0...i].value) | ||
| require(msg.value == valAccumulator, 'Multicall3: value mismatch'); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+139
to
+175
| function aggregate3Value(Call3Value[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 valAccumulator; | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3Value calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| uint256 val = calli.value; | ||
| // Humanity will be a Type V Kardashev Civilization before this overflows - andreas | ||
| // ~ 10^25 Wei in existence << ~ 10^76 size uint fits in a uint256 | ||
| unchecked { | ||
| valAccumulator += val; | ||
| } | ||
| (result.success, result.returnData) = calli.target.call{value: val}(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x84) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| // Finally, make sure the msg.value = SUM(call[0...i].value) | ||
| require(msg.value == valAccumulator, 'Multicall3: value mismatch'); | ||
| } |
Check warning
Code scanning / Slither
Too many digits Warning
Comment on lines
+139
to
+175
| function aggregate3Value(Call3Value[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 valAccumulator; | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3Value calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| uint256 val = calli.value; | ||
| // Humanity will be a Type V Kardashev Civilization before this overflows - andreas | ||
| // ~ 10^25 Wei in existence << ~ 10^76 size uint fits in a uint256 | ||
| unchecked { | ||
| valAccumulator += val; | ||
| } | ||
| (result.success, result.returnData) = calli.target.call{value: val}(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x84) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| // Finally, make sure the msg.value = SUM(call[0...i].value) | ||
| require(msg.value == valAccumulator, 'Multicall3: value mismatch'); | ||
| } |
Check warning
Code scanning / Slither
Too many digits Warning
Comment on lines
+139
to
+175
| function aggregate3Value(Call3Value[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 valAccumulator; | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3Value calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| uint256 val = calli.value; | ||
| // Humanity will be a Type V Kardashev Civilization before this overflows - andreas | ||
| // ~ 10^25 Wei in existence << ~ 10^76 size uint fits in a uint256 | ||
| unchecked { | ||
| valAccumulator += val; | ||
| } | ||
| (result.success, result.returnData) = calli.target.call{value: val}(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x84) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| // Finally, make sure the msg.value = SUM(call[0...i].value) | ||
| require(msg.value == valAccumulator, 'Multicall3: value mismatch'); | ||
| } |
Check warning
Code scanning / Slither
Too many digits Warning
Comment on lines
+139
to
+175
| function aggregate3Value(Call3Value[] calldata calls) public payable returns (Result[] memory returnData) { | ||
| uint256 valAccumulator; | ||
| uint256 length = calls.length; | ||
| returnData = new Result[](length); | ||
| Call3Value calldata calli; | ||
| for (uint256 i = 0; i < length; ) { | ||
| Result memory result = returnData[i]; | ||
| calli = calls[i]; | ||
| uint256 val = calli.value; | ||
| // Humanity will be a Type V Kardashev Civilization before this overflows - andreas | ||
| // ~ 10^25 Wei in existence << ~ 10^76 size uint fits in a uint256 | ||
| unchecked { | ||
| valAccumulator += val; | ||
| } | ||
| (result.success, result.returnData) = calli.target.call{value: val}(calli.callData); | ||
| assembly { | ||
| // Revert if the call fails and failure is not allowed | ||
| // `allowFailure := calldataload(add(calli, 0x20))` and `success := mload(result)` | ||
| if iszero(or(calldataload(add(calli, 0x20)), mload(result))) { | ||
| // set "Error(string)" signature: bytes32(bytes4(keccak256("Error(string)"))) | ||
| mstore(0x00, 0x08c379a000000000000000000000000000000000000000000000000000000000) | ||
| // set data offset | ||
| mstore(0x04, 0x0000000000000000000000000000000000000000000000000000000000000020) | ||
| // set length of revert string | ||
| mstore(0x24, 0x0000000000000000000000000000000000000000000000000000000000000017) | ||
| // set revert string: bytes32(abi.encodePacked("Multicall3: call failed")) | ||
| mstore(0x44, 0x4d756c746963616c6c333a2063616c6c206661696c6564000000000000000000) | ||
| revert(0x00, 0x84) | ||
| } | ||
| } | ||
| unchecked { | ||
| ++i; | ||
| } | ||
| } | ||
| // Finally, make sure the msg.value = SUM(call[0...i].value) | ||
| require(msg.value == valAccumulator, 'Multicall3: value mismatch'); | ||
| } |
Check warning
Code scanning / Slither
Too many digits Warning
roman-gnativ
deleted the
romangnativ/reg-1409-add-multicall-to-sandbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding multicall3 to the sandbox + deployed addresses to uns config. Here is some info about multicall: https://www.multicall3.com/
https://linear.app/unstoppable-domains/issue/REG-1409/create-service-to-check-usdc-balance-and-approved-amount-for-provided
PR Checklist
1. Contracts versioning
patchversion of the contracts is increased if changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts.minorversion of the contracts is increased if breaking changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.jsonis increased if changes have been made to the config.ens-config.jsonis increased if changes have been made to the config.resolver-keys.jsonis increased if changes have been made to the config.ens-resolver-keys.jsonis increased if changes have been made to the config.5. Package versioning
patchversion of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minorversion of package is synced with version ofUNSRegistrycontract.CHANGELOGis updated with short description for the new version.6. Code review
resolver-keys.jsoncode review is required from DevTools teamens-resolver-keys.jsoncode review is required from DevTools team