-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client): add _url
& _ajax_url
helper methods
#384
base: master
Are you sure you want to change the base?
Conversation
There are significant differences in the interfaces and fields between |
Got it, thanks for claryfying. There's already a method that uses Web API (showcase). So the idea is that if it's already used (I did not add it) is to make it kinda more generic What about the methods like comments from my other PR that returns 404 now? And that method with |
@upbit please tell me what you think about adding just |
# Conflicts: # pixivpy3/aapi.py
Both |
@upbit I have removed the |
What this PR does?
_url
and_ajax_url
helper methods to the class to omit boilerplate formatting;TODO:
After this PR is merged (I hope), I would like to make all constants actual constants. It will allow us to reuse code and have it in one place even more