Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

feat(check-diff): generate check-diff output #168

Merged
merged 1 commit into from
Aug 29, 2021
Merged

feat(check-diff): generate check-diff output #168

merged 1 commit into from
Aug 29, 2021

Conversation

haarchri
Copy link
Member

Signed-off-by: Christopher Haar [email protected]

Description of your changes

@hasheddan missed few stuff in my branch we merged with #167 - one commit was missing - now the feature is working - sorry for that

13:43:20 [ .. ] checking that branch is clean
13:43:20 [ OK ] branch is clean

13:47:06 [ .. ] checking that branch is clean
M Makefile
13:47:06 [FAIL]
make: *** [check-diff] Error 1

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

crossplane/provider-aws

@hasheddan hasheddan merged commit b9e5c80 into upbound:master Aug 29, 2021
@haarchri haarchri mentioned this pull request Aug 29, 2021
Closed
2 tasks
@haarchri haarchri mentioned this pull request Oct 21, 2021
Closed
6 tasks
@turkenh turkenh mentioned this pull request Feb 7, 2022
Open
@turkenh turkenh mentioned this pull request Nov 23, 2022
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasheddan hasheddan hasheddan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haarchri @hasheddan