Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --log-encoding cli option #324

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

Antrakos
Copy link
Contributor

@Antrakos Antrakos commented Feb 11, 2025

Description of your changes

Fixes #323

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Built and ran docker image locally. Deployed to one of my development clusters and verified json log ingestion into my ELK.

@Upbound-CLA
Copy link

Upbound-CLA commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@ytsarev
Copy link
Member

ytsarev commented Feb 18, 2025

/test-examples="examples/workspace-inline-aws.yaml"

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you so much for your contribution! 👍

@ytsarev ytsarev merged commit 656ae53 into upbound:main Feb 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add json logging option
3 participants