feat: support set commit using GitHub API using #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olblak , what do you think? |
|
While I like this very much, I think I would like to solve updatecli/updatecli#2195 first. |
olblak
reviewed
Jul 17, 2024
olblak
previously approved these changes
Jul 17, 2024
v1v
added a commit
to v1v/updatecli.policies
that referenced
this pull request
Sep 9, 2024
part of updatecli#28
Merged
v1v
added a commit
to v1v/updatecli.policies
that referenced
this pull request
Sep 16, 2024
a regression when enabling updatecli#28
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable
commitusingapiwhich defines if Updatecli should use GitHub GraphQL API to create the commit. This requires--experimental, but I have not found a way to validate if--experimentalis not configured then don't honourcommitusingapi.I added the changelog entries but I didn't bump the versions.
Test
I added
commitusingapi: truein the test-data.Additional Information
Tradeoff
Potential improvement