Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: adopt Go TLS/HTTP serving best practices #127

Closed
adg opened this issue Dec 20, 2016 · 1 comment
Closed

auth: adopt Go TLS/HTTP serving best practices #127

adg opened this issue Dec 20, 2016 · 1 comment
Assignees
@n2vi
Milestone
open source release

Comments

@adg
Copy link
Collaborator

adg commented Dec 20, 2016

As described here: https://blog.gopheracademy.com/advent-2016/exposing-go-on-the-internet/

We should also move the code that sets up a TLS server from package auth to package cloud/https.
@adg adg assigned n2vi Dec 20, 2016
@robpike robpike added this to the release milestone Dec 21, 2016
@n2vi
Copy link
Contributor

n2vi commented Feb 17, 2017

cl 7814

@n2vi n2vi closed this as completed Feb 17, 2017
adg pushed a commit that referenced this issue Feb 17, 2017
@n2vi
cloud/https: add timeouts for abuse prevention
94980d2 
I recall someone had trouble compiling this, but don't
remember the details.  Trying again to see what breaks.

Fixes #127.

Change-Id: I0360f78053c755cb03e94480e9547fe1112ffc18
Reviewed-on: https://upspin-review.googlesource.com/7814
Reviewed-by: Rob Pike <[email protected]>
Reviewed-by: Eduardo Pinheiro <[email protected]>
@n2vi n2vi mentioned this issue Mar 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n2vi n2vi

Labels
None yet
Projects
None yet
Milestone
open source release
Development

No branches or pull requests
3 participants
@robpike @n2vi @adg