Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting on R code #179

Closed
jameslamb opened this issue Oct 24, 2019 · 0 comments
Closed

Add linting on R code #179

jameslamb opened this issue Oct 24, 2019 · 0 comments

Comments

@jameslamb
Copy link
Collaborator

We should use a linter to somewhat-standardize the style of the R code in this project. For R code, I'm fond of the covr package.

To close this issue, introduce linting in the tests run on Travis. This issue will involve reading our .travis.yml and the scripts in .ci/ to get an understanding of how uptasticsearch's Continuous Integration (CI) setup.

I recommend taking an approach similar to the one in microsoft/LightGBM#2437, but it's up to you (the contributor) to propose how you want to handle it.

This is a medium-difficulty issue, but one you can do without understanding anything about Elasticsearch or uptasticsearch's R code.

@jameslamb jameslamb changed the title Add linting on R code in the project Add linting on R code Oct 24, 2019
geraudster added a commit to geraudster/uptasticsearch that referenced this issue Oct 30, 2019
geraudster added a commit to geraudster/uptasticsearch that referenced this issue Oct 30, 2019
jameslamb added a commit to jameslamb/uptasticsearch that referenced this issue Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant