Refactor/mbl misc updates #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
approved these changes
Jan 28, 2021
| </html>"), | ||
| Icon( | ||
| graphics={ | ||
| Rectangle( |
| function destructor | ||
| "Some comment" | ||
| extends Modelica.Icons.Function; | ||
| input Integer input2; |
| @@ -77,6 +77,7 @@ func main() { | |||
| } | |||
| if flag.NArg() == 0 { | |||
| fmt.Fprintln(os.Stderr, "error: must provide at least one file or directory") | |||
| usage() | |||
There was a problem hiding this comment.
usage reports the command line arguments?
There was a problem hiding this comment.
Yeah, previously it would just say "error: ..." but having usage below the error will be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
MBL requires some edits after running modelica-fmt. This attempts to address a few of those changes they require.
This PR does not address the need to break on long lines inside of non-model level annotations, which is known to be desired (see here: lbl-srg/modelica-buildings@7a2cc97#diff-cc373b9f69fcbc72e7c1ac989931c40bbd538461512f666dc9ca977bc28018a8R51-R54).
Changes