Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/travis config #7

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Fix/travis config #7

merged 5 commits into from
Jun 18, 2020

Conversation

macintoshpie
Copy link
Contributor

@macintoshpie macintoshpie commented Jun 17, 2020

Changes

  • changed the module name to modelica-fmt rather than modelicafmt. As a result the when building the executable you should use go build -o modelicafmt

Fixes

  • fixed the travis configuration for running goreleaser. Now, whenever we push a tag, travis will use goreleaser to build executables and upload them as assets on the release.

@macintoshpie
Copy link
Contributor Author

@nllong do we want the build to still produce an executable named modelicafmt rather than modelica-fmt? If so I can update the goreleaser config

@macintoshpie macintoshpie requested a review from nllong June 17, 2020 20:52
@nllong
Copy link
Member

nllong commented Jun 17, 2020

Yeah, I think i like modelicafmt more.

@@ -10,7 +10,7 @@ import (
"strings"

"github.com/antlr/antlr4/runtime/Go/antlr"
"github.com/urbanopt/modelicafmt/thirdparty/parser"
"github.com/urbanopt/modelica-fmt/thirdparty/parser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice...

@@ -21,13 +21,28 @@ To run the example:

The resulting .mo file can be diffed to the previous file to compare how the modelica-fmt updates the file.

## Usage with pre-commit framework
After adding modelicafmt to your system path, add the following lines to your .pre-commit-config.yaml file under the `repos:` section
```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit looks good. I'll test an make sure this works with the GMT project, even though most of the files are .mot and not .mo.

@nllong nllong merged commit 1f9fb29 into develop Jun 18, 2020
@nllong nllong deleted the fix/travis-config branch June 18, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants