Don't generate fish completion for hidden commands

Added the missing test case as well. Signed-off-by: Sascha Grunert <[email protected]>
urfave · Sep 11, 2019 · bac5bde · bac5bde
1 parent b207e20
commit bac5bde
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/docs_test.go b/docs_test.go
@@ -53,6 +53,9 @@ func testApp() *App {
 		Usage:   "retrieve generic information",
 	}, {
 		Name: "some-command",
+	}, {
+		Name:   "hidden-command",
+		Hidden: true,
 	}}
 	app.UsageText = "app [first_arg] [second_arg]"
 	app.Usage = "Some app"

diff --git a/fish.go b/fish.go
@@ -69,6 +69,10 @@ func (a *App) prepareFishCommands(commands []Command, allCommands *[]string, pre
 	for i := range commands {
 		command := &commands[i]
 
+		if command.Hidden {
+			continue
+		}
+
 		var completion strings.Builder
 		completion.WriteString(fmt.Sprintf(
 			"complete -r -c %s -n '%s' -a '%s'",