-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver) #925
Comments
I don't think this has enough details to understand the problem. |
Stumbled upon that as well. We have code as follows
It produces this error message:
HTH! |
Let me guess, you are not using go modules or any form of vendoring and pull stuff straight from master and build against that? |
You know, I had this same question 😅 and our main author has it covered: I have since been informed that we'll probably need to update this code to match the API change. (On it.) |
Well this was an intended change to a new version of the API, so I guess you just have to fix your side of things. We expect potentially one more of these breaking changes next year. |
ok, but change manual.md , line 547:
|
@skillful-alex please refer to the v2 manual for the latest documentation. |
For any Go noobs out there like me, here's how I repaired my app:
You can see my commit here: Guestlogix/pat@02d0481 |
Oh no! I'm so sorry everyone, we had no idea people were using the package from the As described above, you'll want to do either of the following things:
There's a few things we can do in this repo:
|
@hussamd, @jangaraj, @maxcnunes, @sybnex, @nathancoleman-wf, @max0ne, @juansc if you are still having this issue, can you let me know where you're experiencing it? I'm trying to chase down all of the projects that need to be fixed. |
2nd try ~! @hussamd, @jangaraj, @maxcnunes, @sybnex, @nathancoleman-wf, @max0ne, @juansc if any of you are still experiencing issues, please followup with me! |
@lynncyrin My team pinned this repo to the last working version a while ago |
Thank for that information! It looks like everyone's issue here was that they were using this library straight from master, which causes obvious issues whenever we need to release a new major version. The fix here is to do either of the following things:
I'm going to copy paste this a few times on related issues, so that everyone is aware of the solution here. |
@lynncyrin thanks for the follow up. We also pinned the repo but we'll look at the steps to migrate from v1 to v2. |
I've been compiling migration instructions here => https://github.com/urfave/cli/releases/tag/v2.0.0 ^^ |
Here is the fix for this issue! => #925 (comment)
edited by @lynncyrin!
After the last 2 months there was an error:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
In commit ebc2565 error not exists.
In corrent master error exists.
The text was updated successfully, but these errors were encountered: