Fix(issue #631). Remove reflect calls for Hidden field #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
requested review from
rliebz and
coilysiren
and removed request for
a team
rliebz
approved these changes
Mar 26, 2021
coilysiren
requested review from
a team
and removed request for
coilysiren and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This removes the burden of having to use reflect calls to enforce hidden flag functionality. This makes the interface for Visible flags explicit rather than assuming that the user will have a field name "Hidden" in their flag implementation
Which issue(s) this PR fixes:
Fixes #631
Special notes for your reviewer:
Testing
go test ./...
Release Notes
User flag implementation need to implement VisibleFlag interface to allow their custom flags to be hidden/visible