Add test case for short option handling #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
requested review from
rliebz and
coilysiren
and removed request for
a team
coilysiren
requested review from
a team
and removed request for
rliebz and
coilysiren
dearchap
changed the title
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
Closing this as it has become stale. |
|
Bump
…On Sat, Aug 28, 2021 at 12:07 PM stale[bot] ***@***.***> wrote:
Closed #1260 <#1260>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1260 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYNLZTQXXY7KLCI25IIRM3T7ECS5ANCNFSM4Z57NOLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant. |
|
Ping. Simple change and its just in test code . @coilysiren @rliebz |
meatballhat
changed the title
meatballhat
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erminated error
What type of PR is this?
What this PR does / why we need it:
The short options handling needs to restart from failed processing rather than from beginning of arguments
Which issue(s) this PR fixes:
Fixes #1254
Special notes for your reviewer:
Testing
go test -run=TestSliceShortOptionHandle ./...
Release Notes