Fix:(issue_976) All positional args and flags to be mixed in any order #1987
+106
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
changed the title
BlackHole1
requested changes
Oct 14, 2024
BlackHole1
reviewed
Oct 15, 2024
BlackHole1
requested changes
Oct 17, 2024
danhunsaker
approved these changes
Oct 19, 2024
This was referenced Oct 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Working towards making positions arguments and flags interchangeable
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #976
Fixes #1928
Fixes #1733
Special notes for your reviewer:
(fill-in or delete this section)
Focus on command.parseFlags which has the logic
Testing
(fill-in or delete this section)
All tests have been updated to ensure they work
Release Notes
(REQUIRED)