-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestampFlag docs #997
Conversation
Reason for this PR is that it makes the CI fail until urfave#987 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve if the CI is working and the related PR got merged :)
This won't pass until the changes that have been merged are tagged. When Now we have two ways to move forward, make a release with a feature without having the documentation supporting the feature or, to just merge this as it's only documentation and we all know the exact reason for the CI failure. |
From a functionality point of view, this is what I would like => #1006
This is my preference for the time being 👍 |
Editing this on my phone, not 100% sure if this will work but we'll see
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
=========================================
Coverage ? 72.83%
=========================================
Files ? 33
Lines ? 2474
Branches ? 0
=========================================
Hits ? 1802
Misses ? 565
Partials ? 107
Continue to review full report at Codecov.
|
Finally this works! Phew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋, I just found some formatting nits. 👇
formatting nits
Reason for this PR is that it makes the CI fail until #987 is merged