Skip to content

Commit

Permalink
fix(*): dont run typings on postinstall
Browse files Browse the repository at this point in the history
close #13
  • Loading branch information
urish committed Feb 21, 2016
1 parent 9e6838c commit bfe3f93
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 0.4.1 - 2015-02-21
- Don't run `typings install` on postinstall (fixes [#13](https://github.com/urish/angular2-moment/issues/13))

## 0.4.0 - 2015-02-16
- Switch from `tsd` to `typings`, stop publishing the `moment.js` typings to npm.
- Additional unit-tests
Expand Down
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ and install all needed dependencies via **npm**:

`npm install`

Finally, install the required typescript definitions:

`npm run install_typings`

Well done! angular2-moment is now installed and ready to be built.

## Building
Expand All @@ -35,7 +39,7 @@ the development process. The following npm scripts are provided:
#### npm test

`npm test` compiles the typescript code into javascript, and then runs the unit
tests, which are located in `TimeAgoPipe.spec.ts`. The task uses the **karma** test
tests, which are located in `*.spec.ts`. The task uses the **karma** test
runner to executes the tests with the **jasmine testing framework**.

#### npm run prepublish
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Installation

`npm install --save angular2-moment`

If you use typescript, and [https://github.com/typings/typings](typings), you may also need to install typings for moment.js:

`typings install --save moment`

Usage
-----

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"CHANGELOG.md"
],
"scripts": {
"postinstall": "typings install",
"install_typings": "typings install",
"test": "tslint *.ts && typings install && tsc && karma start",
"prepublish": "typings install && tsc"
},
Expand Down

0 comments on commit bfe3f93

Please sign in to comment.