Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: elasticsearch support #1427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thanhpt1708
Copy link

No description provided.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 94.50%. Comparing base (7d0f5fb) to head (f2452ba).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
fastapi_pagination/ext/elasticsearch.py 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
- Coverage   96.46%   94.50%   -1.96%     
==========================================
  Files          35       36       +1     
  Lines        1302     1329      +27     
==========================================
  Hits         1256     1256              
- Misses         46       73      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uriyyo
Copy link
Owner

uriyyo commented Jan 19, 2025

Hi @thanhpt1708,

Thanks for PR, could you also add tests for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants