Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[layout] Lines shouldn't break when encountering emoji #30

Closed
usadson opened this issue Aug 29, 2023 · 0 comments
Closed

[layout] Lines shouldn't break when encountering emoji #30

usadson opened this issue Aug 29, 2023 · 0 comments
Assignees
@usadson
Labels
🐛 bug Something isn't working 💄 css Related to CSS parsing and/or the representation
Milestone
v0.3.0

Comments

@usadson
Copy link
Owner

usadson commented Aug 29, 2023

image

The problem is that emoji rendering uses a different font, so it requires to switch to another LayoutBoxFragment. Currently, breaking a fragment means continuing on a new line, but that shouldn't be the case for this fragment specifically.
@usadson usadson added 🐛 bug Something isn't working 💄 css Related to CSS parsing and/or the representation labels Aug 29, 2023
@usadson usadson added this to the v0.3.0 milestone Aug 29, 2023
@usadson usadson self-assigned this Aug 29, 2023
usadson added a commit that referenced this issue Aug 29, 2023
@usadson
[layout] Fix that emojis break LineBoxFragments
62e98f8 
Fixes issue #30.
@usadson usadson closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usadson usadson

Labels
🐛 bug Something isn't working 💄 css Related to CSS parsing and/or the representation
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@usadson