Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual and Documentation #106

Closed
WGC575 opened this issue Nov 16, 2023 · 3 comments · Fixed by #118
Closed

Manual and Documentation #106

WGC575 opened this issue Nov 16, 2023 · 3 comments · Fixed by #118
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@WGC575
Copy link
Collaborator

WGC575 commented Nov 16, 2023

I will add documentations as I learn and understand each component of ARCADE.

@WGC575 WGC575 self-assigned this Nov 16, 2023
@WGC575 WGC575 added the documentation Improvements or additions to documentation label Nov 16, 2023
WGC575 added a commit that referenced this issue Nov 21, 2023
Synchronize documentation with master. #106
@MarceloLaser
Copy link
Contributor

I updated the documentation and added a "tentative" generic renamer.py, since the original renamer.py was pretty hard-coded. I did not test renamer.py, so I recommend doing that before merging this branch.

Also, the docs make reference to a major difference in run_clustering.py. Could I have access to the new version of it? It may be better to, instead of merging those functions into run_clustering.py, create another script that encapsulates all of those functions. The reason for keeping these scripts separate is to minimize re-runs when something crashes, so combining all those phases into a single script may be counter-productive for some problematic subject systems.

@WGC575
Copy link
Collaborator Author

WGC575 commented Nov 21, 2023

I updated the documentation and added a "tentative" generic renamer.py, since the original renamer.py was pretty hard-coded. I did not test renamer.py, so I recommend doing that before merging this branch.

Also, the docs make reference to a major difference in run_clustering.py. Could I have access to the new version of it? It may be better to, instead of merging those functions into run_clustering.py, create another script that encapsulates all of those functions. The reason for keeping these scripts separate is to minimize re-runs when something crashes, so combining all those phases into a single script may be counter-productive for some problematic subject systems.

@MarceloLaser Hi Marcelo, could you give more information about the "major difference" you mentioned? Since I didn't update run_clustering.py, there might be some misunderstanding of the code from my side.

@MarceloLaser
Copy link
Contributor

My mistake, I misunderstood the documentation. Going back to it, your description is correct, just missing some context. I've pushed another commit to add that context. It is still missing instructions on some of the scripts, but I assume those will come later. It could also use a script for RecovAr, I'll see if I get the time to make one. Thanks for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants