Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XXH32 instead of sha256 for const hashing #1393

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Use XXH32 instead of sha256 for const hashing #1393

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbfd4e7
use much simpler fnv instead of sha256 for const hashing
xermicus Sep 13, 2022
46beecb
Merge branch 'master' into cl/const-storage-key-with-stable-rust
xermicus Sep 16, 2022
df85b09
update key tests for fnv1a
xermicus Sep 16, 2022
aae9523
switch to xxhash32
xermicus Sep 16, 2022
3256c28
update UI tests with new keys
xermicus Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/primitives/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ derive_more = { version = "0.99", default-features = false, features = ["from",
ink_prelude = { version = "4.0.0-alpha.1", path = "../prelude/", default-features = false }
scale = { package = "parity-scale-codec", version = "3", default-features = false, features = ["derive", "full"] }
scale-info = { version = "2", default-features = false, features = ["derive"], optional = true }
sha2-const = { version = "0.1.2", default-features = false }
const-fnv1a-hash = "1.1.0"
athei marked this conversation as resolved.
Show resolved Hide resolved

[features]
default = ["std"]
Expand Down
33 changes: 12 additions & 21 deletions crates/primitives/src/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

use const_fnv1a_hash::fnv1a_hash_32;
use ink_prelude::vec;
use sha2_const::Sha256;

/// A key into the smart contract storage.
///
Expand All @@ -33,18 +33,12 @@ impl KeyComposer {
/// Concatenate two `Key` into one during compilation.
pub const fn concat(left: Key, right: Key) -> Key {
// If one of the keys is zero, then return another without hashing.
// If both keys are non-zero, return the hash of both keys.
// If both keys are non-zero, return the hash of the XOR difference of both keys.
match (left, right) {
(0, 0) => 0,
(0, _) => right,
(_, 0) => left,
(left, right) => {
let hash = Sha256::new()
.update(&left.to_be_bytes())
.update(&right.to_be_bytes())
.finalize();
Key::from_be_bytes([hash[0], hash[1], hash[2], hash[3]])
}
(left, right) => fnv1a_hash_32(&(left ^ right).to_be_bytes(), None),
}
}

Expand All @@ -59,8 +53,7 @@ impl KeyComposer {
return 0
}

let hash = Sha256::new().update(bytes).finalize();
Key::from_be_bytes([hash[0], hash[1], hash[2], hash[3]])
fnv1a_hash_32(bytes, None)
}

/// Evaluates the storage key of the field in the structure, variant or union.
Expand All @@ -69,8 +62,7 @@ impl KeyComposer {
/// 1. If `variant_name` is not empty then computes the ASCII byte representation and call it `V`.
/// 1. Compute the ASCII byte representation of `field_name` and call it `F`.
/// 1. Concatenate (`S` and `F`) or (`S`, `V` and `F`) using `::` as separator and call it `C`.
/// 1. Apply the `SHA2` 256-bit hash `H` of `C`.
/// 1. The first 4 bytes of `H` make up the storage key.
/// 1. The `FNV1A` 32-bit hash of `C` is the storage key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xermicus this should be XXHASH instead, eh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙈

///
/// # Note
///
Expand Down Expand Up @@ -99,7 +91,6 @@ impl KeyComposer {
} else {
vec![struct_name.as_bytes(), field_name.as_bytes()].join(separator)
};

Ok(Self::from_bytes(composed_key.as_slice()))
}
}
Expand All @@ -119,33 +110,33 @@ mod tests {
fn concat_works_correct() {
assert_eq!(KeyComposer::concat(0, 13), 13);
assert_eq!(KeyComposer::concat(31, 0), 31);
assert_eq!(KeyComposer::concat(31, 13), 0xD83A5CD8);
assert_eq!(KeyComposer::concat(31, 13), 0x3995d8bf);
assert_eq!(KeyComposer::concat(0, 0), 0);
}

#[test]
fn from_str_works_correct() {
assert_eq!(KeyComposer::from_str(""), 0);
assert_eq!(KeyComposer::from_str("123"), 0xa665a459);
assert_eq!(KeyComposer::from_str("Hello world"), 0x64ec88ca);
assert_eq!(KeyComposer::from_str("123"), 0x7238631b);
assert_eq!(KeyComposer::from_str("Hello world"), 0x594d29c7);
}

#[test]
fn from_bytes_works_correct() {
assert_eq!(KeyComposer::from_bytes(b""), 0);
assert_eq!(KeyComposer::from_bytes(b"123"), 0xa665a459);
assert_eq!(KeyComposer::from_bytes(b"Hello world"), 0x64ec88ca);
assert_eq!(KeyComposer::from_bytes(b"123"), 0x7238631b);
assert_eq!(KeyComposer::from_bytes(b"Hello world"), 0x594d29c7);
}

#[test]
fn compute_key_works_correct() {
assert_eq!(
KeyComposer::compute_key("Contract", "", "balances"),
Ok(0x05e859ec)
Ok(0xe26930c6)
);
assert_eq!(
KeyComposer::compute_key("Enum", "Variant", "0"),
Ok(0x9d029590)
Ok(0x9e253b67)
);
assert_eq!(
KeyComposer::compute_key("", "Variant", "0"),
Expand Down