Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query args with percent % say they save, but don't properly update save status #1339

Closed
tanj opened this issue Jan 6, 2024 · 3 comments
Closed

Comments

@tanj
Copy link

tanj commented Jan 6, 2024

The file gets written, but the dirty marker does not clear.

image

@adarshlilha
Copy link
Contributor

As per my findings, when % is used in query param value, item.draft has reference to itself(the item object), due to which the circle marker is still shown and unsaved changes popup is shown on closing the tab

@adarshlilha
Copy link
Contributor

bruno electron watcher calls change method onSave of request each time

here file.data = bruToJson(bru); is being called to parse the request using ohm js library
Error is thrown in parse method while trying to validate the input const match = grammar.match(input);

example input: 'meta { name: percent req type: http seq: 1}post { url: https://jsonplaceholder.typicode.com/posts?item=21% body: none auth: none}query { item: 21%}';

output: URI malformed, parsing fails when % is used in query
Screenshot 2024-01-19 at 02 40 23

@helloanoop I guess a fix will be needed when ohm. grammar is initialized, any pointers?

@sanjai0py
Copy link
Member

I have resolved this issue as it has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants