Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace recursive variables #1173

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion packages/bruno-electron/src/ipc/network/interpolate-vars.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,46 @@ const interpolateEnvVars = (str, processEnvVars) => {
});
};

const interpolateCollectionVars = (str, processEnvVars, processCollectionVariables) => {
if (!str || !str.length || typeof str !== 'string') {
return str;
}

const template = Handlebars.compile(str, { noEscape: true });

const output = template({
...processEnvVars,
...processCollectionVariables,
process: {
env: {
...processCollectionVariables
}
}
});

// Check if returned string has any more variables to interpolate
if (output.includes('{{') && output.includes('}}')) {
return interpolateCollectionVars(output, processEnvVars, processCollectionVariables);
}

return output;
};

const interpolateVars = (request, envVars = {}, collectionVariables = {}, processEnvVars = {}) => {
// we clone envVars because we don't want to modify the original object
envVars = cloneDeep(envVars);
collectionVariables = cloneDeep(collectionVariables);

// envVars can inturn have values as {{process.env.VAR_NAME}}
// so we need to interpolate envVars first with processEnvVars
forOwn(envVars, (value, key) => {
envVars[key] = interpolateEnvVars(value, processEnvVars);
});

Object.entries(collectionVariables).map(([key, value]) => {
collectionVariables[key] = interpolateCollectionVars(value, envVars, collectionVariables);
});

const interpolate = (str) => {
if (!str || !str.length || typeof str !== 'string') {
return str;
Expand All @@ -58,7 +88,14 @@ const interpolateVars = (request, envVars = {}, collectionVariables = {}, proces
}
};

return template(combinedVars);
const output = template(combinedVars);

// Check if returned string has any more variables to interpolate
if (output.includes('{{') && output.includes('}}')) {
return interpolate(output);
}

return output;
};

request.url = interpolate(request.url);
Expand Down