fix(#263): Replace vm2 with fork of vm2 to fix security issues #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsefcik
approved these changes
Jan 16, 2024
|
Thank you @Its-treason ! |
This was referenced Jan 30, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
vm2with@n8n/vm2a fork of vm2 that fixes 2 security vulnerabilities.Closes #263 #922
PSA: While this closes sandbox escape vulnerabilities, you should always make sure not to run random/untrusted scripts. Bruno allows script's to access
node:fsand other modules (If enabled in bruno.json) so be careful with what you run.