fix(#2376): send unmodified request json body #2382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
|
Does this cover #2207, #2438 as well? I would think getting a less destructive JSON parsing library like suggested in one of those issues would be the better/more transparent solution for the end user. The examples brought up by the users in these several issues should probably be added to the tests if there is any for this to ensure behavior as well. |
2 tasks
|
CLosing since this was addressed in PR #2773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2376, #2362, #1768
added a checkbox in the collection settings' presets tab to choose if the request body should be parsed and de-commented, or be sent as it is needs to be added
(part of the bruno config presets)
raw_json_toggle.mov
currently bruno supports adding comments in the json body
and before the actual request is made the comments are removed and the body is parsed as json
ref: PR