Fix/bigint in response #2736
Merged
Fix/bigint in response #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its-treason
force-pushed
the
fix/bigint-in-response
branch
from
64ae016 to
9f99a31
Compare
|
Would be nice to throw it on the request side to to solve #2438 as well |
It looks like this is already working
|
|
I am not seeing that behavior, the latest version of bruno is still converting large numbers in JSON body to strings. |
|
Merged! Thanks for taking care of this @Its-treason ! |
2 tasks
helloanoop
added a commit
that referenced
this pull request
Aug 6, 2024
This reverts commit 3e2a3b6.
helloanoop
added a commit
that referenced
this pull request
Aug 6, 2024
|
Hey @Its-treason I reverted this merge since we are planning a release today. It appears we may have to fork axios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
lossless-jsonto parse the response data and then later stringily so information about BigInts are not lost.Fixes: #1753