Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TRACE to OpenAPI allowed methods during import #2783

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

NiklasBr
Copy link
Contributor

@NiklasBr NiklasBr commented Aug 8, 2024

Description

In #2117 it was discovered by @nicolasne that the TRACE method caused an issue on import, this is an attempt at adding it to the list of allowed methods.

TRACE is already supported in other OpenAPI Collection locations such as

return Object.entries(methods)
.filter(([method, op]) => {
return ['get', 'put', 'post', 'delete', 'options', 'head', 'patch', 'trace'].includes(
method.toLowerCase()
);
})

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines. (but unfortunately I had created the branch name before I read the guidelines, hope that is okay)
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 4c3fe2f into usebruno:main Aug 8, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @NiklasBr !

@NiklasBr NiklasBr deleted the 2117-add-trace-method branch November 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants