fix: update GitHub Actions permissions for checks and pull requests #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramki-bruno
approved these changes
Jan 18, 2025
Closed
5 tasks
ramki-bruno
reviewed
Jan 20, 2025
.github/workflows/tests.yml
Outdated
| @@ -7,6 +7,8 @@ on: | |||
|
|
|||
| permissions: | |||
| contents: read | |||
| checks: write | |||
| pull-requests: write | |||
There was a problem hiding this comment.
You can add this permissions per job using jobs.<job_id>.permissions.
But its not something I would worry about and probably not worth creating a new job(upload and download atrifacts etc.).
sanjaikumar-bruno
force-pushed
the
main
branch
from
212689c to
fee631d
Compare
|
I accidentally pushed the changes from my main, and when reverting these unmerged changes, the branch got reset. I raised a new PR #3844 with the changes suggested from this review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist: