Feature/always indent json in queryresult #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2023 11:55
The mode is returned by getCodeMirrorModeBasedOnContentType(), which always prefixes the returned values with 'application/'. However returning data on those application/html or application/text break Bruno.
Some APIs return the wrong Content-Type 'application/html', but valid JSON as payload. In this cases the data is still typeof object and a indented JSON makes it easier to work with. However JSON folding and highlighting will still be off in this case.
|
Hey, @Joschasa, I think it would be better if we instead edit the I think you can just pass the body to |
|
Hi @Its-treason, is this what you had in mind? |
Yes, and you should be able to revert the changes to the Looks good, nice work! |
This reverts commit 76a26b6.
Its-treason
approved these changes
Nov 1, 2023
|
Any update on this? |
|
Merged. Thank you @Joschasa for getting this done! Thank you for reviewing this @Its-treason ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An unused condition was removed and the QueryPreview window should always indent the JSON payload.
Even for APIs with a Content-Type info of "application/html".
Before:
(Headers:)
After:
However the resulting JSON is not highlighted / foldable, as the CodeEditor still treats this as HTML.
We could leave this as is, so that one might recognize the API returns the wrong Content-Type.
Contribution Checklist: