-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: use ratio instead of max width
- Loading branch information
Showing
1 changed file
with
5 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4790e84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the ration be set lower than 0.8 (e.g. 0.2) or can we have a setting to change the ration manually.
The goal of creating thumbnails is to limit the amount of data going over the network to speed up the page/image loading.
If we only make the files a little bit smaller the page load time doesnt go down much and our storage usage increases at almost double the rate with these larger thumbnails
e.g.
in v0.25 uploading a 4000 x 3000px image (camera photo) would store a
170kb
thumbnail and a3.5mb
image.with the above change the same image now stores a
2.9mb
thumbnail and a3.5mb
image.That difference in total thumbnail size escalates quickly as more images are added
As an alternative, if the thumbnail max width is used again and is upped from 700px to 900px then the widest view area in the site is covered and the thumbnails stay small in size
4790e84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoccoSmit Good points, but I feel like it could be implemented after someone gives feedback. Let's keep it simple first! And I will change the default ratio to
0.5
.