Skip to content

Commit

Permalink
chore: remove access token after sign out
Browse files Browse the repository at this point in the history
  • Loading branch information
boojack committed May 20, 2024
1 parent 21838d0 commit fb15386
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
7 changes: 4 additions & 3 deletions server/router/api/v1/acl.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const (
// The key name used to store username in the context
// user id is extracted from the jwt token subject field.
usernameContextKey ContextKey = iota
accessTokenContextKey
)

// GRPCAuthInterceptor is the auth interceptor for gRPC server.
Expand Down Expand Up @@ -74,9 +75,9 @@ func (in *GRPCAuthInterceptor) AuthenticationInterceptor(ctx context.Context, re
return nil, errors.Errorf("user %q is not admin", username)
}

// Stores userID into context.
childCtx := context.WithValue(ctx, usernameContextKey, username)
return handler(childCtx, request)
ctx = context.WithValue(ctx, usernameContextKey, username)
ctx = context.WithValue(ctx, accessTokenContextKey, accessToken)
return handler(ctx, request)
}

func (in *GRPCAuthInterceptor) authenticate(ctx context.Context, accessToken string) (string, error) {
Expand Down
12 changes: 12 additions & 0 deletions server/router/api/v1/auth_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package v1
import (
"context"
"fmt"
"log/slog"
"regexp"
"strings"
"time"
Expand Down Expand Up @@ -214,6 +215,17 @@ func (s *APIV1Service) SignUp(ctx context.Context, request *v1pb.SignUpRequest)
}

func (s *APIV1Service) SignOut(ctx context.Context, _ *v1pb.SignOutRequest) (*emptypb.Empty, error) {
accessToken, ok := ctx.Value(accessTokenContextKey).(string)
// Try to delete the access token from the store.
if ok {
_, err := s.DeleteUserAccessToken(ctx, &v1pb.DeleteUserAccessTokenRequest{
AccessToken: accessToken,
})
if err != nil {
slog.Error("failed to delete access token", err)
}
}

if err := s.clearAccessTokenCookie(ctx); err != nil {
return nil, status.Errorf(codes.Internal, "failed to set grpc header, error: %v", err)
}
Expand Down

0 comments on commit fb15386

Please sign in to comment.