Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: editor tab support #309

Merged
merged 5 commits into from
Oct 19, 2022
Merged

feat: editor tab support #309

merged 5 commits into from
Oct 19, 2022

Conversation

f97-26082023
Copy link
Contributor

chrome-capture-2022-9-18

@boojack boojack requested review from hyoban and removed request for lqwakeup October 18, 2022 13:26
@boojack boojack enabled auto-merge (squash) October 18, 2022 13:26
auto-merge was automatically disabled October 19, 2022 04:18

Head branch was pushed to by a user without write access

@f97-26082023
Copy link
Contributor Author

f97-26082023 commented Oct 19, 2022 •
edited
Loading

@boojack, I still think if is easier to understand, but it's fine for me.

hyoban
hyoban approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@hyoban hyoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking your time, more people think if would be better

image

@f97-26082023
Copy link
Contributor Author

@hyoban , Yeahhhh, I also just remembered I was missing return. Thanks....

@boojack boojack merged commit 24154c9 into usememos:main Oct 19, 2022
@f97-26082023 f97-26082023 deleted the feat/editor-tab-support branch October 19, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack left review comments

@hyoban hyoban hyoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f97-26082023 @boojack @hyoban