Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace unmatchedEmailAndPasswordError with unmatchedUsernameAndPasswordError` #3889

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

haohanyang
Copy link
Contributor

When the user fails to login using username and password on /api/v1/auth/signin, the error message should be unmatched username and password, instead of unmatched email and password

@haohanyang haohanyang requested a review from boojack as a code owner September 7, 2024 08:38
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@boojack boojack changed the title Replace unmatchedEmailAndPasswordError with unmatchedUsernameAndPasswordError` chore: replace unmatchedEmailAndPasswordError with unmatchedUsernameAndPasswordError` Sep 7, 2024
@boojack boojack merged commit 044d46c into usememos:main Sep 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants