buf: specify version of stephenh-ts-proto plugin #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - I was trying to build this locally, and with docker, and kept receiving errors during
pnpm build:While digging through everything - it looks like the plugins used by
bufaren't tracked by any package managers/lockfiles/etc, it seems likebufpulls them in dynamically.Looking at https://buf.build/community/stephenh-ts-proto?version=v2.2.0 - it looks like v2.2.0 came out September 19th and I suspect it generates code that's incompatible with something, because when I changed the buf.gen.yaml file to reference a specific version (the previous one listed) - everything compiles without issue.
I'm guessing there's some dependency that can be updated somewhere to enable stephenh-ts-proto v2+ but in the meantime, seems like it's a good idea to specify plugin versions to known-good versions.
Not sure if the other plugins need to receive the same treatment? I'll be honest, I'm way outside my area of expertise, I just wanted to build the app.