Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pull to refresh for PagedMemoList #4128

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

nlfox
Copy link
Contributor

@nlfox nlfox commented Nov 14, 2024

#1789
Although above issue is fixed, tap to reload still a bit hard to find and non-intuitive, I feel adding pull to refresh feature will make user experience better.

image

Looks like this^

GIF:

image

@nlfox nlfox requested a review from boojack as a code owner November 14, 2024 00:52
@nlfox nlfox force-pushed the main branch 2 times, most recently from 5b29640 to 473f2cb Compare November 14, 2024 01:10
@boojack
Copy link
Member

boojack commented Nov 17, 2024

Can we customize the element of loader, the current one's style doesn't fit Memos very well.

@nlfox
Copy link
Contributor Author

nlfox commented Nov 17, 2024

Can we customize the element of loader, the current one's style doesn't fit Memos very well.

Yes we can, what kind of style do you suggest? do you have some specific icon that you want to use?
Like here: https://loading.io/css/
Or I just reuse elements currently in project like

      <div className="w-full flex flex-row justify-center items-center my-4">
            <LoaderIcon className="animate-spin text-zinc-500" />
          </div>

you can choose one, I will make code change. I can pm you the demo site (in discord maybe?)

Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 3cbccde into usememos:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants