Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support MC 1.21.1 #58

Closed
tim740 opened this issue Oct 19, 2024 · 1 comment · Fixed by #59
Closed

Update to support MC 1.21.1 #58

tim740 opened this issue Oct 19, 2024 · 1 comment · Fixed by #59

Comments

@tim740
Copy link

tim740 commented Oct 19, 2024

Currently, the plugin version: 3.1.0-SNAPSHOT doesn't fully enable and disables its self on MC 1.21.1
Using paper

@minoneer
Copy link
Collaborator

minoneer commented Dec 6, 2024

Also an issue with 1.21.3:

[14:59:51] [Server thread/ERROR]: Error occurred while enabling uSkyBlock v3.1.0-SNAPSHOT (Is it up to date?)
java.lang.IllegalArgumentException: NETHER_PORTAL isn't an item
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) ~[guava-32.1.2-jre.jar:?]
	at org.bukkit.inventory.ItemStack.of(ItemStack.java:58) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:138) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:117) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:104) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:87) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.utils.util.ItemStackUtil.getItemType(ItemStackUtil.java:82) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.utils.util.ItemStackUtil.createItemRequirement(ItemStackUtil.java:38) ~[uSkyBlock.jar:?]
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575) ~[?:?]
	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622) ~[?:?]
	at java.base/java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:627) ~[?:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.challenge.ChallengeFactory.createChallenge(ChallengeFactory.java:52) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.challenge.Rank.<init>(Rank.java:31) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.challenge.ChallengeFactory.createRankMap(ChallengeFactory.java:123) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.challenge.ChallengeLogic.<init>(ChallengeLogic.java:57) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.uSkyBlock.reloadConfigs(uSkyBlock.java:776) ~[uSkyBlock.jar:?]
	at uSkyBlock.jar/us.talabrek.ultimateskyblock.uSkyBlock.onEnable(uSkyBlock.java:227) ~[uSkyBlock.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:655) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:604) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:290) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1235) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:340) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
[14:59:51] [Server thread/INFO]: [uSkyBlock] Disabling uSkyBlock v3.1.0-SNAPSHOT

minoneer added a commit to minoneer/uSkyBlock that referenced this issue Dec 7, 2024
This resolves an issue in newer Spigot versions where non-item blocks in challenge requirements prevent the plugin from loading.
Fixes uskyblock#58
@Muspah Muspah closed this as completed in #59 Dec 9, 2024
Muspah pushed a commit that referenced this issue Dec 9, 2024
* Remove AWE integration

AsynchWorldEdit has been abandoned for over 2 years and does not work with current server versions. We should focus on supporting FAWE going ahead.

* Decouple block from item requirements in challenges

This resolves an issue in newer Spigot versions where non-item blocks in challenge requirements prevent the plugin from loading.
Fixes #58

* Add converter to new challenges format

* Update item conversion tests to new config header

* Add timestamp to challenge file backup to avoid overwriting old backups

* Update the challenges version number after conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants