Fixed the cursor location being reset upon menu click. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't have the time yesterday to check the issue you created, sorry. Tbh, I have no idea what the reasoning behind this was, the menu class needs refactoring at some point because it's a mess, but isn't my real priority as long as the underlying business logic needs changes too. Removing the closeInventory calls looks good to me, but you've also committed the change from PR #14 into this PR. Could you revert that, so we can merge? |
This reverts commit 9f24f6d
|
Reverted. Yeah the menus need some love. I'm trying to sort out another bug as we speak so that I can get my challenges to display properly. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all instances of the closeInventory method in the SkyBlockMenu class. It was serving no purpose other than to frustrate the player by resetting the cursor location on every click.