Skip to content

Commit

Permalink
Updated metaschema submodule to pickup usnistgov/metaschema#208. Reso…
Browse files Browse the repository at this point in the history 
…lves #1260
  • Loading branch information
@david-waltermire
david-waltermire committed May 12, 2022
1 parent 159c1d7 commit ad8bb2f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/metaschema
Submodule metaschema updated 1 files
+104 −0 toolchains/xslt-M4/schema-gen/metaschema-v090-datatypes.json

1 comment on commit ad8bb2f

@Agh42
Copy link
Contributor

@Agh42 Agh42 commented on ad8bb2f May 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to come across as nitpicky but I don' think that this really resolves #1260. It does put the regular expressions back into the JSON schemas.
However my original observation (that I derailed a little bit in the issue) was that there is a mistake in the DateTimeDatatype regex.

This is still:

^((2000|2400|2800|(19|2[0-9](0[48]|[2468][048]|[13579][26])))-02-29)|(((19|2[0-9])[0-9]{2})-02-(0[1-9]|1[0-9]|2[0-8]))|(((19|2[0-9])[0-9]{2})-(0[13578]|10|12)-(0[1-9]|[12][0-9]|3[01]))|(((19|2[0-9])[0-9]{2})-(0[469]|11)-(0[1-9]|[12][0-9]|30))T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\\.[0-9]+)?(Z|[+-][0-9]{2}:[0-9]{2})?$

whereas it probably is supposed to be:

^(((2000|2400|2800|(19|2[0-9](0[48]|[2468][048]|[13579][26])))-02-29)|(((19|2[0-9])[0-9]{2})-02-(0[1-9]|1[0-9]|2[0-8]))|(((19|2[0-9])[0-9]{2})-(0[13578]|10|12)-(0[1-9]|[12][0-9]|3[01]))|(((19|2[0-9])[0-9]{2})-(0[469]|11)-(0[1-9]|[12][0-9]|30)))T(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\.[0-9]+)?(Z|[+-][0-9]{2}:[0-9]{2})$

See the original description in #1260 for visualization.

Please sign in to comment.