Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control Mapping in OSCAL JSON Allows an Empty Relationship Object #1458

Closed
aj-stein-nist opened this issue Sep 16, 2022 · 9 comments · Fixed by #1462
Closed

Control Mapping in OSCAL JSON Allows an Empty Relationship Object #1458

aj-stein-nist opened this issue Sep 16, 2022 · 9 comments · Fixed by #1462
Labels
Model Engineering An issue to be discussed during the bi-weekly Model Engineering Meeting question Scope: Modeling Issues targeted at development of OSCAL formats
Milestone
v1.1.0

Comments

@aj-stein-nist
Copy link
Contributor

aj-stein-nist commented Sep 16, 2022 •
edited
Loading

Question

@openprivacy pointed out today during the OSCAL Model Meeting in the current version of the develop branch's Control Mapping Model as of 37a3f11, the "relationship": {} can be defined as empty. And relationship has a required minimum cardinality of 1. It is not sure this is intentional or an area for improvement.
@aj-stein-nist aj-stein-nist added question Scope: Modeling Issues targeted at development of OSCAL formats Model Engineering An issue to be discussed during the bi-weekly Model Engineering Meeting labels Sep 16, 2022
@iMichaela
Copy link
Contributor

@Compton-NIST - Can you please add this issue to the list of the Control Mapping Model issues you planned on reviewing? Even though issue #1333 documents the need of identifying the gaps, empty relationship is most likely not the desired solution but rather a bug.

@Compton-US
Copy link
Contributor

@iMichaela Will do!

@Compton-US Compton-US self-assigned this Sep 20, 2022
@david-waltermire
Copy link
Contributor

david-waltermire commented Sep 20, 2022 •
edited
Loading

I am not sure this is a schema issue.

Looking at the XML and JSON implementations, the relationship value is required.

This appears to be an issue with the generated documentation instead.

david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Sep 20, 2022
@david-waltermire
Added JSON value key for relationship type. This missing value key wa…
88f57cb 
…s discovered as part of usnistgov#1458.
@david-waltermire david-waltermire mentioned this issue Sep 20, 2022
Merged
9 tasks
david-waltermire added a commit that referenced this issue Sep 20, 2022
@david-waltermire
Added JSON value key for relationship type. This missing value key wa…
f26ce30 
…s discovered as part of #1458. (#1462)
@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Sep 22, 2022
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Sep 22, 2022
@david-waltermire
Copy link
Contributor

@aj-stein-nist investigated this with me and we identified a JSON schema generation bug that is causing this. usnistgov/metaschema#240 was created to fix the schema generation bug. Nothing more to do here until that issue is resolved.

The documentation is also buggy. Issue usnistgov/metaschema#241 was established to fix this.

Once these issues are addressed and the fixes confirmed, this issue can be closed.

@Compton-US
Copy link
Contributor

To do after fixes:

  • Validate that the relationship is correct in the json schema.
  • Review documentation to ensure it is accurate for relationship.

aj-stein-nist pushed a commit that referenced this issue Oct 18, 2022
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
7f7348e 
…s discovered as part of #1458. (#1462)
david-waltermire added a commit that referenced this issue Oct 31, 2022
@david-waltermire
Added JSON value key for relationship type. This missing value key wa…
dcdf2f8 
…s discovered as part of #1458. (#1462)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 10, 2023
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
cf3f589 
…s discovered as part of usnistgov#1458. (usnistgov#1462)
@david-waltermire
Copy link
Contributor

@aj-stein-nist Can you confirm that develop has been updated to point to the latest Metaschema submodule commit?

@david-waltermire david-waltermire linked a pull request Jan 19, 2023 that will close this issue
Mapping Relationship JSON Value Key #1462
Merged
9 tasks
@aj-stein-nist
Copy link
Contributor Author

@aj-stein-nist Can you confirm that develop has been updated to point to the latest Metaschema submodule commit?

This still needs CI/CD fixes, need to circle back of this during the sprint.

aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Feb 6, 2023
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
e42104a 
…s discovered as part of usnistgov#1458. (usnistgov#1462)
@aj-stein-nist
Copy link
Contributor Author

Sigh also blocked by usnistgov/oscal-content#116. Moving to the following sprint after the recently started one. Marking this as blocked.

@aj-stein-nist aj-stein-nist moved this from Under Review to Blocked in NIST OSCAL Work Board Mar 2, 2023
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jun 29, 2023
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
f656518 
…s discovered as part of usnistgov#1458. (usnistgov#1462)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jul 10, 2023
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
46e21da 
…s discovered as part of usnistgov#1458. (usnistgov#1462)
@aj-stein-nist
Copy link
Contributor Author

It appears the relevant work was previously completed and oscal-content testing is no longer necessary, closing.

@github-project-automation github-project-automation bot moved this from Blocked to Done in NIST OSCAL Work Board Jul 27, 2023
aj-stein-nist pushed a commit to galtm/OSCAL that referenced this issue Sep 28, 2023
@david-waltermire @aj-stein-nist
Added JSON value key for relationship type. This missing value key wa…
d7802c2 
…s discovered as part of usnistgov#1458. (usnistgov#1462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Model Engineering An issue to be discussed during the bi-weekly Model Engineering Meeting question Scope: Modeling Issues targeted at development of OSCAL formats
Projects
NIST OSCAL Work Board
Status: Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Mapping Relationship JSON Value Key david-waltermire/OSCAL
4 participants
@david-waltermire @iMichaela @aj-stein-nist @Compton-US