-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Container and Newer Git Enforce Safe Directory Checks #1600
Labels
Comments
5 tasks
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this issue
Jan 5, 2023
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this issue
Jan 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
5 tasks
github-project-automation
bot
moved this from Under Review
to Done
in NIST OSCAL Work Board
Jan 12, 2023
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this issue
Feb 6, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL
that referenced
this issue
Jun 29, 2023
* Fix Dockerfile multi-stage builds, closes #1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov/OSCAL#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL
that referenced
this issue
Jun 29, 2023
* Fix Dockerfile multi-stage builds, closes #1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov/OSCAL#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this issue
Jul 10, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
aj-stein-nist
added a commit
to galtm/OSCAL
that referenced
this issue
Sep 28, 2023
* Fix Dockerfile multi-stage builds, closes usnistgov#1597. * Add maven.restlet.org workaround. If the TLS cert is bad, it will break local build just like maven building Java deps in GHA. * Fix directory safety for doctor, closes usnistgov#1600. * Somehow, docs/run-server.sh set to non-executable again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When doing local development, any script script in the that runs in the docker container or one built and run from said Dockerfile will often have differing file ownership on the host relative to inside the container. This will lead to errors like those in the replication section.
To work around this, you would need to re-run that command within the container every recreation of a container instance from an image, so it would be best to patch that in the Dockerfile itself. Because of how volume mounts work, and a volume mount is always owned by
root
, this is inevitable and ought to be fixed as this feature ofgit
is now in all stable releases for a little bit. We will trust the volume mount.More info and context on StackOverflow and other blogs, I cannot find an official man page source from
git
that I can link to from an Internet-routable URL unforunately.Who is the bug affecting
NIST OSCAL developers who intend to make use of our public
Dockerfile
spec.What is affected by this bug
CI/CD, Tooling & API
How do we replicate this issue
pushd docs
docker compose up -d docs
Observe the error below when the
run-server.sh
or other scripts would run, a similar error would occurs.Expected behavior (i.e. solution)
The entrypoint executes without error.
Other comments
No response
The text was updated successfully, but these errors were encountered: